♻️🐛 [Trusted Types] Make createExtensionScript Trusted Types compatible #39163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
♻️🐛 [Trusted Types] Make createExtensionScript Trusted Types compatible
erwinmombay
approved these changes
Jun 29, 2023
erwinmombay
requested changes
Jun 29, 2023
powerivq
approved these changes
Jun 29, 2023
erwinmombay
approved these changes
Jul 5, 2023
erwinmombay
reviewed
Jul 5, 2023
erwinmombay
approved these changes
Jul 12, 2023
eszponder
pushed a commit
to krzysztofequativ/amphtml
that referenced
this pull request
Apr 22, 2024
…le (ampproject#39163) * extension script tt compatible * Update extension-script.js * testing if base case works * console log url * allow consolelog * fix console log exempt * typo * fix format * updated cdn and allowlist * linter * add fonts to allowlist * Lint and fix logic * Update policy * unused ignore statement * policy pattern change * lint * checking if localhost sufficient * typo * get mode from win * update comment * adding font cdn * check if test detection works * reformat * comment and policy change * reverting to last passing visual test * removing filename limitations * change policy format * linting and format changes * move regex to top level constant * typo --------- Co-authored-by: Ecenaz Ozmen <ecenazo@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates AMP's createExtensionScript function to be Trusted Types compatible, partial fix to #37297. The function was directly setting the scriptElement.src to some variable url. This url is expected to fall under the cdn so we can restrict the host the url takes on to cdn.ampproject.org and return the url as being a TrustedScriptUrl.